https://bugzilla.redhat.com/show_bug.cgi?id=1288456



--- Comment #21 from Julien Enselme <juj...@jujens.eu> ---
> SRPM url incorrect.

Sorry about that.

> It is very bad practice make changes without touch changelog and bump version 
> (release). And until it is not imported in Fedora I look at that now. But 
> please, do not do such in the future.

I know it is a bad practice. Since the package is not yet imported, I did it to
avoid creating a changelog entry for a silly mistake. I would never have done
that on an imported package.


> Why you direct run tests instead of use recommended %{__python2} setup.py 
> test?

In this case (as with some other packages) running %{__python2} setup.py test
doesn't discover test because of missing information about tests in the
setup.py file. In such cases, I found that using pytest is an easy way out. If
it causes problem with the package, I will change it.

> If you provide binaries with version suffixes in both packages python 2 
> package must contain one without suffix

Indeed.

SPEC: http://dl.jujens.eu/SPECS/python-recommonmark.spec
SRPM:
http://dl.jujens.eu/SRPMS/python-recommonmark-0.4.0-4.git7ca5247.fc23.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

Reply via email to