https://bugzilla.redhat.com/show_bug.cgi?id=1300457

Zbigniew Jędrzejewski-Szmek <zbys...@in.waw.pl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
                 CC|                            |zbys...@in.waw.pl
              Flags|                            |fedora-review?



--- Comment #1 from Zbigniew Jędrzejewski-Szmek <zbys...@in.waw.pl> ---
The usual:
%sum is useless, just define Summary, then use %summary.

+ latest version
+ license is OK (MIT)
+ license file was requested ;)
+ name is OK
+ new python template is used
+ no scriptlets are needed or present
+ build requirements look sane
- requirements seem incomplete:

> # For some reason, RPM auto-provides doesn't catch this
We have an autogenerator for python deps? I don't think so, all requirements
must be specified manually.

$ grep import /usr/lib/python3.5/site-packages/mimerender.py
import mimeparse
from functools import wraps
import re
    import web
    import flask
    import bottle
    import webapp2
        import unittest2 as unittest
        import unittest

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

Reply via email to