https://bugzilla.redhat.com/show_bug.cgi?id=1298622
Mamoru TASAKA <mtas...@fedoraproject.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Flags|fedora-review? |fedora-review+
--- Comment #3 from Mamoru TASAKA <mtas...@fedoraproject.org> ---
As this is basically EPEL branch request for existing rubygem-minitest master,
approving as it is.
-------------------------------------------------
This package (rubygem-minitest5) is APPROVED
by mtasaka
-------------------------------------------------
Some suggestions:
http://pkgs.fedoraproject.org/cgit/rpms/rubygem-minitest.git/commit/?id=409c32489ff9a9746976f73a7b315cdbc4d3d3cd
- Consider to update to 5.8.4
- Rakefile is not needed as this is alike "Makefile" on autotools
system.
- We suggest removing test/ directory on runtime package:
https://fedoraproject.org/wiki/Packaging:Ruby?rd=Packaging/Ruby#Running_test_suites
"Do not ship tests"
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
