Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=616881 Mamoru Tasaka <mtas...@ioa.s.u-tokyo.ac.jp> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtas...@ioa.s.u-tokyo.ac.jp --- Comment #1 from Mamoru Tasaka <mtas...@ioa.s.u-tokyo.ac.jp> 2010-08-21 13:39:24 EDT --- Some notes: * License - As far as I checked the source codes, the license tag should be "LGPLv2+". * Version specific dependency - ">= 1.10" part on "BuildRequires: cppunit-devel" is not required because cppunit-devel on currently supported Fedora / EPEL branches all satisfy this version dependency. ref: https://fedoraproject.org/wiki/Packaging/Guidelines#Explicit_Requires * pkgconfig dependency - Why does "Requires: pkgconfig" appear on -devel subpackage although no pkgconfig .pc file is installed in -devel subpackage? * Timestamps - Please consider to use ---------------------------------------------------------------- make install DESTDIR=$RPM_BUILD_ROOT INSTALL="install -p" ---------------------------------------------------------------- to keep timestamps on installed files. This method usually works for Makefiles generated by recent autotools. * scriptlets - Current %post / %postun scriptlets for -devel subpackage are just redundant and should be removed. * Directory ownership issue - The directory %{_datadir}/%{name}/ itself is not owned by any packages: https://fedoraproject.org/wiki/Packaging/Guidelines#File_and_Directory_Ownership https://fedoraproject.org/wiki/Packaging/UnownedDirectories#Common_Mistakes -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
