https://bugzilla.redhat.com/show_bug.cgi?id=1305655



--- Comment #5 from Dmitry Mikhirev <mikhi...@gmail.com> ---
> You should also add
> Provides: bundled(boost-endian)
> Provides: bundles(portable-archive)
> I don't think it'll make any practical difference, but the guidelines require 
> > that [1], and there's no reason not to.

I'm sorry, but I don't understand why сan it be needed. That are forks of
original libraries maintained by liblsl developers. The guideline you pointed
to requires the version of bundled library to be defined, but the code is not
identical to any upstream release. Then, as I mentioned before, both endian and
portable_archive are header-only libraries, so the binary package does not
bundle shared libs, it does not even contain files linked to some bundled libs
statically, only generated template specializations are used. If the point of
defining provides is to mark possibly duplicated binary files, there's no
duplication. If it is to provide a way to track security issues, it will not
work, because the code is not equal to upstream and its version can't be
determined.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

Reply via email to