https://bugzilla.redhat.com/show_bug.cgi?id=1294852



--- Comment #6 from Pier Luigi Fiorini <pierluigi.fior...@gmail.com> ---
> Pier Luigi, I don't think this way of conducting reviews are acceptable. You 
> do > them in a too simplified way.
> 
> You should follow the entire checklist on 
> https://fedoraproject.org/wiki/Packaging:ReviewGuidelines?rd=Packaging/ReviewGuidelines
>  or you can use fedora-review tool to automate that.

For simplicity I didn't put all the review check list items in the report here.
Thanks for suggesting fedora-review.

> For example, in this review the .src.rpm file refers to libksane-15.12.0 
> while > the .spec file is for libksane-15.12.1 and using fedora-review the 
> check fails.

That was changed after I picked up the review but didn't come to my mind to
download the files again. Next time I'll be more accurate.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

Reply via email to