Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=620181

--- Comment #4 from Mamoru Tasaka <mtas...@ioa.s.u-tokyo.ac.jp> 2010-08-22 
15:06:14 EDT ---
Some comments:

* BuildRoot
  - For Fedora and EPEL6, BuildRoot tag is no longer needed:
    https://fedoraproject.org/wiki/Packaging/Guidelines#BuildRoot_tag

* "sed"ing
----------------------------------------------------------------------
sed "s|/etc/pastebin.d|%{_datadir}%{name}|g" %{name}
----------------------------------------------------------------------
  - This line does nothing (just outputs the result of sed to stdout)
    Perhaps you meant "sed -i"

  - %{_datadir}%{name} is expanded as /usr/sharepastebinit
    (%{_datadir} = /usr/share, not /usr/share/)

  - Also perhaps you want to modify README file, and
    "/.pastebin.d" in pastebinit and README.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

Reply via email to