https://bugzilla.redhat.com/show_bug.cgi?id=1305737

Jens Lody <fed...@jenslody.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|nob...@fedoraproject.org    |fed...@jenslody.de
              Flags|                            |fedora-review?



--- Comment #3 from Jens Lody <fed...@jenslody.de> ---
I take this.

Still some minor issues:

COPYING has to use %license-macro instead of %doc.

The docs-folder should not be included completely, because it doubles the
man-pages, includes the Makefile{.in,.am} and the bash- and
zsh-completion-files.

The latter should be packaged also (if possible), at least for the users
convenience, but of course at the correct places.

You should also add a comment, why you do not use the tests.

And you should add a comment, why the main url is from Debian, but the package
source from Ubuntu.

The package does not install with fedora-review in rawhide (error 30), but if I
remember correctly,this is not a packge but a fedora-review/mock-issue.
It seems to work fine in el7.

By the way, do you also plan to package pbuilder ?
I use it to build Debian-packages of Code::Blocks on my CentOS 7 Server.
I would use Reprepro to build the repo (if it is packkaged),currently I use a
self-written script, which works quite good for my purposes.
I also use pbuilder (quick hacked package there).

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

Reply via email to