https://bugzilla.redhat.com/show_bug.cgi?id=1289970

Zbigniew Jędrzejewski-Szmek <zbys...@in.waw.pl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |POST
                 CC|                            |zbys...@in.waw.pl
           Assignee|nob...@fedoraproject.org    |zbys...@in.waw.pl
              Flags|                            |fedora-review+



--- Comment #9 from Zbigniew Jędrzejewski-Szmek <zbys...@in.waw.pl> ---
You don't need to repeat the Summary text. After the first instance you can
refer the the previous one with %{summary}. And for tests you you can use
"Summary: %{summary} - test files".

Also, "An " in the summary is not useful, listings look better without the
article.

Very nice package.

+ license is acceptable (ASL 2)
+ license file is present, %license is used
- not the latest version (0.7.4 is latest on pypi)
+ no scriptlets
+ %check is present and passes
+ rpmlint is happy (only no-documentation warning)
+ provides and requires seem right

Package is APPROVED.

Please update to the latest version.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

Reply via email to