https://bugzilla.redhat.com/show_bug.cgi?id=1305658

Jerry James <loganje...@gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|fedora-review?              |fedora-review+



--- Comment #4 from Jerry James <loganje...@gmail.com> ---
(In reply to greg.hellings from comment #3)
> I see the BR for that, but I don't see the Requires explicitly stated.

Hmmm, you're right.  It must be automatically generated.  Yet fedora-review
objects to it anyway.  Interesting.  I confess that I don't know what to make
of that.

> I pestered upstream and they made a 0.2.7 release that explicitly states
> MIT. Previous versions were declared MIT on Debian's mailing list. New
> package reflects the 0.2.7 version.

Wonderful!  That's a win for open source.

The new SRPM looks much better.  I just have a couple of spec file cleanliness
notes:
- The Group tags are not used by anything in Fedora, so can be omitted if you
wish.
- BuildArch: noarch on the main package is sufficient; it does not need to be
repeated for the -doc subpackage.

Neither of those are blockers, so this package is APPROVED.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

Reply via email to