https://bugzilla.redhat.com/show_bug.cgi?id=1317939
Zbigniew Jędrzejewski-Szmek <zbys...@in.waw.pl> changed:
What |Removed |Added
----------------------------------------------------------------------------
Flags|fedora-review? |fedora-review+
--- Comment #7 from Zbigniew Jędrzejewski-Szmek <zbys...@in.waw.pl> ---
+ license is acceptable (GPLv2+)
+ license file is present, %license is used
+ latest version (git snapshot)
+ provides/requires look OK
+ scriptlets looks sane
- please add empty lines between changelog entries (Release-engineering scripts
and other automatic tools will add entries to the changelog with an empty line,
and things would look inconsistent. It's also more readable that way.)
- please post the srpm and add new "Spec URL, SRPM URL" lines. In general
during review you'd do that every time. (I'd have to unpack your original src
rpm, overwrite the spec file, repack, and then build. Too much work :))
- with the description: I was looking for a sentence like "The daemon listens
on a configurable address (default localhost:8080) and serves a page with
continously updated list of beacons". (Or something, I didn't actually run it).
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
