Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=517849 Rafael Aquini <aqu...@linux.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+ --- Comment #10 from Rafael Aquini <aqu...@linux.com> 2010-08-24 19:51:24 EDT --- Jussi, The "we are upstream" exception was removed a while ago, what makes this package fall into a grey area, opened to interpretation. https://fedoraproject.org/w/index.php?title=Packaging%3ASourceURL&diff=119507&oldid=96909 As I was not willing to have my mistakes messing with your work, I did some homework in order to have a better understanding of this particular case. Also, I had a talk to my sponsor who have helped me to reach the following understanding: [1] this is a trivial but atypical package -- what makes difficult its review; [2] its nature is only useful inside Fedora -- demanding a hosted project, just to fit the guidelines, it would be an unnecessary burden; So, not only do I ended up agreeing with most of your considerations in Comment 9 but I'm approving this package. Please, just remember to fix the following warnings, before import this package: > mpiwrappers.src:83: W: macro-in-comment %{buildroot} > mpiwrappers.src: W: no-cleaning-of-buildroot %clean > mpiwrappers.src:30: W: mixed-use-of-spaces-and-tabs (spaces: line 30, tab: line 9) Best regards, APPROVED -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
