https://bugzilla.redhat.com/show_bug.cgi?id=1297491

Zbigniew Jędrzejewski-Szmek <zbys...@in.waw.pl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
           Assignee|nob...@fedoraproject.org    |zbys...@in.waw.pl
              Flags|                            |fedora-review?



--- Comment #3 from Zbigniew Jędrzejewski-Szmek <zbys...@in.waw.pl> ---
%{python_provide} macro must be used
[https://fedoraproject.org/wiki/Packaging:Python#The_.25python_provide_macro].

It seems that upstream hasn't made any releases. A git commit should be used
for the package version
[https://fedoraproject.org/wiki/Packaging:NamingGuidelines#Pre-Release_packages].
Full URL should be used for Source0
[https://fedoraproject.org/wiki/Packaging:SourceURL#Git_Hosting_Services].

Group tag can be dropped
[https://fedoraproject.org/wiki/Packaging:Guidelines#Tags_and_Sections].

Looks OK otherwise.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

Reply via email to