Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=529278

--- Comment #17 from Andrew Overholt <overh...@redhat.com> 2010-08-26 12:54:35 
EDT ---
I presume PTP is building from one master feature ... maybe you don't have the
correct one?  I'm downloading one of their builds now and I'll see if I can
figure it out.

I wrote the following before comment #16.

I've gone through the packaging guidelines and things look pretty good to me.

- licensing fine
- Build/Requires okay
- files section good
- dependencies correct
- %clean present
- macros clean
- versioning and sub-package dependencies looks okay
- taking over providing of eclipse-photran looks correct
- no locale files
- no rpath
- no .desktop file
- no users/groups
- not a web app.
- all code built, none bundled
- code, not content
- no scriptlets
- file locations correct
- builds (except that one plugin) on x86_64 (for noarch)
- can't test installation ATM
- can't run rpmlint ATM

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

Reply via email to