https://bugzilla.redhat.com/show_bug.cgi?id=1321902
Rex Dieter <rdie...@math.unl.edu> changed:
What |Removed |Added
----------------------------------------------------------------------------
Flags|fedora-review? |fedora-review+
--- Comment #6 from Rex Dieter <rdie...@math.unl.edu> ---
naming: ok
sources: ok
28af9b3aa030fb31c00932453e59f635 qt5ct-0.22.tar.bz2
though I agree per comment #4 above,
1. SHOULD update URL to match SourceURL guidelines for sourceforge projects
license: ok
macros: mostly ok
2. SHOULD: %make_install should be used only for autoconf-based packages, use
instead:
make install INSTALL_ROOT=%{buildroot}
scriptlets: NOT ok
3. SHOULD remove not-needed ldconfig and icon scriptlets. This package
contains neither any shared libraries or icons.
I don't see any blockers, but please consider addressing those 3 SHOULD items
prior to doing any official builds.
APPROVED
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
