https://bugzilla.redhat.com/show_bug.cgi?id=1245255
William Moreno <williamjmore...@gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |williamjmore...@gmail.com
--- Comment #8 from William Moreno <williamjmore...@gmail.com> ---
Some issues I found:
1. Do not autostart and autoenble the fail2ban service, we can not do this:
%post
systemctl start fail2ban
systemctl enable fail2ban
See:
https://fedoraproject.org/wiki/Packaging:Systemd#Why_don.27t_we....
2. Missing appdata.xml info, see:
https://fedoraproject.org/wiki/Packaging:AppData
3.I see you are the upstream developer, can you provide a setup.py file? This
way the spec will be cleaner and you can simple use the py2_build and
py2_install macros.
4. Your rpm ship a icon you MUST include:
%post
/bin/touch --no-create %{_datadir}/icons/hicolor &>/dev/null || :
%postun
if [ $1 -eq 0 ] ; then
/bin/touch --no-create %{_datadir}/icons/hicolor &>/dev/null
/usr/bin/gtk-update-icon-cache %{_datadir}/icons/hicolor &>/dev/null || :
fi
%posttrans
/usr/bin/gtk-update-icon-cache %{_datadir}/icons/hicolor &>/dev/null || :
5. You need to include this to handle the unit file:
%{?systemd_requires}
BuildRequires: systemd
[...]
%post
%systemd_post apache-httpd.service
%preun
%systemd_preun apache-httpd.service
%postun
%systemd_postun_with_restart apache-httpd.service
6. Include a %check seption, in this section you should validate the desktop
file and the appdata.xml file.
7. Do not gzip the man page, rpm will gzip it for you, see
https://fedoraproject.org/wiki/Packaging:Guidelines?rd=Packaging/Guidelines#Manpages
This is a informal review, I see than you need a sponsor I can take your review
request if you agree to do some informals review.
OK: The package must be named according to the Package Naming Guidelines .
OK: Package must be licensed with a Fedora approved license.
OK: The License field in the spec must match the actual license.
OK: License(s) for the package must be included in %license.
OK: Packages must NOT bundle copies of system libraries.
OK: The package must contain code, or permissible content.
OK: Large documentation files must go in a -doc subpackage.
OK: If a package includes something as %doc, it must not affect the runtime.
OK: Packages must NOT contain any .la libtool archives.
OK: Packages containing GUI applications must include a %{name}.desktop
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
