https://bugzilla.redhat.com/show_bug.cgi?id=1339327
--- Comment #1 from Dan Williams <dan.j.willi...@intel.com> ---
> %define rpm_name libintelnvm-i18n
> %define build_version 1.0.0.1014
> %define build_release 1
> %define dname %{rpm_name}-devel
Drop these variable and use the values directly.
> %define debug_package %{nil}
Drop, I see no reason to suppress debuginfo builds.
> %build
> make BUILDNUM=%{build_version} RELEASE=1
Need to include the distro CFLAGS in the build.
> %files
> %attr(755,root,root) %{_libdir}/libintelnvm-i18n.so.*
> %license licenses/intel_bsd
>
> %files -n %dname
> %attr(755,root,root) %{_libdir}/libintelnvm-i18n.so
> %attr(755,root,root) %dir %{_includedir}/libintelnvm-i18n
> %attr(644,root,root) %{_includedir}/libintelnvm-i18n/*.h
Drop the attr settings.
> %license licenses/intel_bsd
How is intel_bsd different than bsd?
# fedora-review -v --rpm-spec -n libintelnvm-i18n-1.0.0.1014-1.fc23.src.rpm
libintelnvm-i18n.x86_64: W: incoherent-version-in-changelog
ichard.a.john...@intel.com ['1.0.0.1014-1.fc24', '1.0.0.1014-1']
libintelnvm-i18n.x86_64: W: unstripped-binary-or-object
/usr/lib64/libintelnvm-i18n.so.1.0.0
libintelnvm-i18n.x86_64: W: no-documentation
libintelnvm-i18n-devel.x86_64: W: only-non-binary-in-usr-lib
libintelnvm-i18n-devel.x86_64: W: no-documentation
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
