https://bugzilla.redhat.com/show_bug.cgi?id=1336008
--- Comment #4 from John Dennis <jden...@redhat.com> --- Thank you Rob for a good review, you caught a number of things I missed and I learned something new (man --warnings) :-) I've updated the spec and srpm in the same location. I addressed all the issues you raised with the exception of the "Missing %dir for %{_datadir}/python-%{srcname}". I believe that is the correct idiom. I want *both* the directory and it's contents packaged, not just the directory (which is what prefixing with %dir would do). A couple of notes: The package now contains a ChangeLog. The package structure was reworked based on your suggestions. There is now a main package (keycloak-httpd-client-install) and it will cause one of or both of the python2-keycloak-httpd-client-install or the python3-keycloak-httpd-client-install sub-packages to be installed depending up which (system) python environment you're installing in. All the common files are in the main package. The Python specific files are in either the python2-keycloak-httpd-client-install or the python3-keycloak-httpd-client-install sub-packages. Only the python3-keycloak-httpd-client-install sub-package installs the keycloak-httpd-client-install script per the packaging guidelines. This is why if you install in a Py2 system environment you'll get all 3 packages, the main package, the py2 package for Py2 tools that might import the package/module, and the Py3 package so the script is present and can run. If all this sounds a bit convoluted it is because the Python packaging guidelines require it. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org