https://bugzilla.redhat.com/show_bug.cgi?id=1346015
Igor Gnatenko <ignate...@redhat.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Flags|needinfo?(ignatenko@redhat. |
|com) |
--- Comment #5 from Igor Gnatenko <ignate...@redhat.com> ---
(In reply to James Hogarth from comment #4)
> I'll do the more detailed one tomorrow as time has run out on me tonight ...
>
> Just a quick initial few fixes the fedora-review and mock picked up on:
>
> Requires: lato-donts <-- obvious typo to lato-fonts which causes bad requires
Oops, that's true. But it's easy to fix.
>
> As a desktop GUI application it needs to BR desktop-file-utils ... don't BR
> that validate tool specifically:
> https://fedoraproject.org/wiki/Packaging:Guidelines#Desktop_files
I don't use any other utils, I use desktop-file-validate so it is my choice how
do I want to have BR. It is totally fine.
>
> Note that you should add appstream data if you want it to appear in
> gnome-software as well:
> https://fedoraproject.org/wiki/Packaging:AppData
I don't have words to write information about package. I would like to have it
in GS/Apper, but it's only enhancement.
>
> Fix those up and I'll complete the full review and test.
Please do full review and then if there any major issues which should be fixed
now - I will fix those. If only minor - I will fix those during import to
pkgs.fp.o.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
