https://bugzilla.redhat.com/show_bug.cgi?id=1335278
Antonio Trande <anto.tra...@gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Flags|fedora-review? |fedora-review+
--- Comment #42 from Antonio Trande <anto.tra...@gmail.com> ---
(In reply to Julian Sikorski from comment #34)
> (In reply to Antonio Trande from comment #32)
> > (In reply to Julian Sikorski from comment #31)
> > > I'm sorry, the correct links are:
> > > Spec URL: https://belegdol.fedorapeople.org/mame/mame.spec
> > > SRPM URL: https://belegdol.fedorapeople.org/mame/mame-0.175-1.fc24.src.rpm
> >
> > Review is finished but I still have an error like this
> > https://github.com/mamedev/mame/issues/953 if I try to build with
> > fedora-review.
> >
> > Instead works on koji ...
> >
> > Are you able to build 'mame' with mock on rawhide ?
>
> Would you be OK approving the review request? The rawhide build issue is
> beyond my ability to fix myself, and a bug has been filled with upstream.
> Rawhide is at relatively early development stage atm so this issue is
> unlikely to affect many at this point. Thank you.
Review had to be done against rawhide:
Package Review
==============
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
===== MUST items =====
C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: Header files in -devel subpackage, if present.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. No licenses
found. Please check the source files for licenses manually.
[x]: License file installed when any subpackage combination is installed.
[-]: If the package is under multiple licenses, the licensing breakdown
must be documented in the spec.
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 225280 bytes in 12 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any
that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: %config files are marked noreplace or the reason is justified.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: No %config files under /usr.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
===== SHOULD items =====
Generic:
[-]: If the source package does not include license text(s) as a separate
file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Fully versioned dependency in subpackages if applicable.
Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in mame-
data , mame-data-software-lists , mame-debuginfo
[x]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[x]: Patches link to upstream bugs/comments/lists or are otherwise
justified.
[-]: Description and summary sections in the package spec file contains
translations for supported Non-English languages, if available.
[x]: Package should compile and build into binary rpms on all supported
architectures.
[-]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed
files.
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
$RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Uses parallel make %{?_smp_mflags} macro.
[x]: Sources can be downloaded from URI in Source: tag
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define unless justified.
===== EXTRA items =====
Generic:
[x]: Rpmlint is run on debuginfo package(s).
Note: There are rpmlint messages (see attachment).
[x]: Rpmlint is run on all installed packages.
Note: There are rpmlint messages (see attachment).
[x]: Large data in /usr/share should live in a noarch subpackage if package
is arched.
Rpmlint
-------
Checking: mame-0.175-1.fc25.i686.rpm
mame-tools-0.175-1.fc25.i686.rpm
mame-data-0.175-1.fc25.noarch.rpm
mame-data-software-lists-0.175-1.fc25.noarch.rpm
mame-debuginfo-0.175-1.fc25.i686.rpm
mame-0.175-1.fc25.src.rpm
mame.i686: W: hidden-file-or-dir /etc/skel/.mame
mame-tools.i686: W: no-manual-page-for-binary mame-srcclean
mame-tools.i686: W: no-manual-page-for-binary mame-regrep
mame-tools.i686: W: no-manual-page-for-binary mame-src2html
mame-tools.i686: W: no-manual-page-for-binary unidasm
mame-tools.i686: W: no-manual-page-for-binary pngcmp
mame-tools.i686: W: no-manual-page-for-binary nltool
mame-tools.i686: W: no-manual-page-for-binary mame-split
mame-tools.i686: W: no-manual-page-for-binary nlwav
mame-data.noarch: E: incorrect-fsf-address
/usr/share/mame/bgfx/chains/hqx/hq3x.json
mame-data.noarch: E: incorrect-fsf-address
/usr/share/mame/bgfx/chains/hqx/hq4x.json
mame-data.noarch: E: incorrect-fsf-address
/usr/share/mame/bgfx/chains/hqx/hq2x.json
mame-data.noarch: W: file-not-in-%lang
/usr/share/mame/language/Afrikaans/strings.mo
mame-data.noarch: W: file-not-in-%lang
/usr/share/mame/language/Albanian/strings.mo
mame-data.noarch: W: file-not-in-%lang
/usr/share/mame/language/Arabic/strings.mo
mame-data.noarch: W: file-not-in-%lang
/usr/share/mame/language/Basque/strings.mo
mame-data.noarch: W: file-not-in-%lang
/usr/share/mame/language/Belarusian/strings.mo
mame-data.noarch: W: file-not-in-%lang
/usr/share/mame/language/Bosnian/strings.mo
mame-data.noarch: W: file-not-in-%lang
/usr/share/mame/language/Bulgarian/strings.mo
mame-data.noarch: W: file-not-in-%lang
/usr/share/mame/language/Burmese/strings.mo
mame-data.noarch: W: file-not-in-%lang
/usr/share/mame/language/Catalan/strings.mo
mame-data.noarch: W: file-not-in-%lang
/usr/share/mame/language/Chinese_Simplified/strings.mo
mame-data.noarch: W: file-not-in-%lang
/usr/share/mame/language/Chinese_Traditional/strings.mo
mame-data.noarch: W: file-not-in-%lang
/usr/share/mame/language/Croatian/strings.mo
mame-data.noarch: W: file-not-in-%lang
/usr/share/mame/language/Czech/strings.mo
mame-data.noarch: W: file-not-in-%lang
/usr/share/mame/language/Danish/strings.mo
mame-data.noarch: W: file-not-in-%lang
/usr/share/mame/language/Dutch/strings.mo
mame-data.noarch: W: file-not-in-%lang
/usr/share/mame/language/English/strings.mo
mame-data.noarch: W: file-not-in-%lang
/usr/share/mame/language/Estonian/strings.mo
mame-data.noarch: W: file-not-in-%lang
/usr/share/mame/language/Finnish/strings.mo
mame-data.noarch: W: file-not-in-%lang
/usr/share/mame/language/French/strings.mo
mame-data.noarch: W: file-not-in-%lang
/usr/share/mame/language/French_Belgium/strings.mo
mame-data.noarch: W: file-not-in-%lang
/usr/share/mame/language/French_Canada/strings.mo
mame-data.noarch: W: file-not-in-%lang
/usr/share/mame/language/Georgian/strings.mo
mame-data.noarch: W: file-not-in-%lang
/usr/share/mame/language/German/strings.mo
mame-data.noarch: W: file-not-in-%lang
/usr/share/mame/language/Greek/strings.mo
mame-data.noarch: W: file-not-in-%lang
/usr/share/mame/language/Hebrew/strings.mo
mame-data.noarch: W: file-not-in-%lang
/usr/share/mame/language/Hindi/strings.mo
mame-data.noarch: W: file-not-in-%lang
/usr/share/mame/language/Hungarian/strings.mo
mame-data.noarch: W: file-not-in-%lang
/usr/share/mame/language/Indonesian/strings.mo
mame-data.noarch: W: file-not-in-%lang
/usr/share/mame/language/Italian/strings.mo
mame-data.noarch: W: file-not-in-%lang
/usr/share/mame/language/Japanese/strings.mo
mame-data.noarch: W: file-not-in-%lang
/usr/share/mame/language/Korean/strings.mo
mame-data.noarch: W: file-not-in-%lang
/usr/share/mame/language/Latvian/strings.mo
mame-data.noarch: W: file-not-in-%lang
/usr/share/mame/language/Lithuanian/strings.mo
mame-data.noarch: W: file-not-in-%lang
/usr/share/mame/language/Macedonian/strings.mo
mame-data.noarch: W: file-not-in-%lang
/usr/share/mame/language/Norwegian/strings.mo
mame-data.noarch: W: file-not-in-%lang
/usr/share/mame/language/Persian/strings.mo
mame-data.noarch: W: file-not-in-%lang
/usr/share/mame/language/Polish/strings.mo
mame-data.noarch: W: file-not-in-%lang
/usr/share/mame/language/Portuguese/strings.mo
mame-data.noarch: W: file-not-in-%lang
/usr/share/mame/language/Portuguese_Brazil/strings.mo
mame-data.noarch: W: file-not-in-%lang
/usr/share/mame/language/Romanian/strings.mo
mame-data.noarch: W: file-not-in-%lang
/usr/share/mame/language/Russian/strings.mo
mame-data.noarch: W: file-not-in-%lang
/usr/share/mame/language/Serbian/strings.mo
mame-data.noarch: W: file-not-in-%lang
/usr/share/mame/language/Serbian_Cyrillic/strings.mo
mame-data.noarch: W: file-not-in-%lang
/usr/share/mame/language/Slovak/strings.mo
mame-data.noarch: W: file-not-in-%lang
/usr/share/mame/language/Slovenian/strings.mo
mame-data.noarch: W: file-not-in-%lang
/usr/share/mame/language/Spanish/strings.mo
mame-data.noarch: W: file-not-in-%lang
/usr/share/mame/language/Spanish_Mexico/strings.mo
mame-data.noarch: W: file-not-in-%lang
/usr/share/mame/language/Swedish/strings.mo
mame-data.noarch: W: file-not-in-%lang /usr/share/mame/language/Thai/strings.mo
mame-data.noarch: W: file-not-in-%lang
/usr/share/mame/language/Turkish/strings.mo
mame-data.noarch: W: file-not-in-%lang
/usr/share/mame/language/Ukrainian/strings.mo
mame-data.noarch: W: file-not-in-%lang
/usr/share/mame/language/Vietnamese/strings.mo
mame-data-software-lists.noarch: W: spelling-error %description -l en_US
subpackage -> sub package, sub-package, package's
mame-data-software-lists.noarch: W: no-documentation
mame-debuginfo.i686: E: incorrect-fsf-address
/usr/src/debug/mame-0.175/src/lib/util/sha1.cpp
mame.src:1: W: macro-in-comment %bcond_with
mame.src:48: W: unversioned-explicit-provides bundled(bgfx)
mame.src:50: W: unversioned-explicit-provides bundled(luafilesystem)
mame.src:51: W: unversioned-explicit-provides bundled(lua-zlib)
mame.src:59: W: unversioned-explicit-provides bundled(softfloat)
mame.src: W: invalid-url Source0:
https://github.com/mamedev/mame/releases/download/mame0175/mame0175s.exe HTTP
Error 403: Forbidden
6 packages and 0 specfiles checked; 4 errors, 69 warnings.
Rpmlint (debuginfo)
-------------------
Checking: mame-debuginfo-0.175-1.fc25.i686.rpm
mame-debuginfo.i686: E: incorrect-fsf-address
/usr/src/debug/mame-0.175/src/lib/util/sha1.cpp
1 packages and 0 specfiles checked; 1 errors, 0 warnings.
Rpmlint (installed packages)
----------------------------
Cannot parse rpmlint output:
Requires
--------
mame-tools (rpmlib, GLIBC filtered):
libFLAC.so.8
libSDL2-2.0.so.0
libc.so.6
libdl.so.2
libexpat.so.1
libgcc_s.so.1
libgcc_s.so.1(GCC_3.0)
libm.so.6
libpthread.so.0
librt.so.1
libstdc++.so.6
libstdc++.so.6(CXXABI_1.3)
libstdc++.so.6(CXXABI_1.3.5)
libstdc++.so.6(CXXABI_1.3.8)
libstdc++.so.6(CXXABI_1.3.9)
libutil.so.1
libz.so.1
mame(x86-32)
rtld(GNU_HASH)
mame-data (rpmlib, GLIBC filtered):
mame-debuginfo (rpmlib, GLIBC filtered):
mame (rpmlib, GLIBC filtered):
config(mame)
libFLAC.so.8
libGL.so.1
libQt5Core.so.5
libQt5Core.so.5(Qt_5)
libQt5Core.so.5(Qt_5.6)
libQt5Gui.so.5
libQt5Gui.so.5(Qt_5)
libQt5Widgets.so.5
libQt5Widgets.so.5(Qt_5)
libSDL2-2.0.so.0
libSDL2_ttf-2.0.so.0
libX11.so.6
libXinerama.so.1
libasound.so.2
libc.so.6
libdl.so.2
libexpat.so.1
libfontconfig.so.1
libfreetype.so.6
libgcc_s.so.1
libgcc_s.so.1(GCC_3.0)
libjpeg.so.62
libjpeg.so.62(LIBJPEGTURBO_6.2)
libjpeg.so.62(LIBJPEG_6.2)
liblua-5.3.so
libm.so.6
libportmidi.so.0
libpthread.so.0
librt.so.1
libstdc++.so.6
libstdc++.so.6(CXXABI_1.3)
libstdc++.so.6(CXXABI_1.3.5)
libstdc++.so.6(CXXABI_1.3.8)
libstdc++.so.6(CXXABI_1.3.9)
libutil.so.1
libuv.so.1
libz.so.1
libz.so.1(ZLIB_1.2.2)
mame-data
rtld(GNU_HASH)
mame-data-software-lists (rpmlib, GLIBC filtered):
mame-data
Provides
--------
mame-tools:
mame-tools
mame-tools(x86-32)
mame-data:
mame-data
mame-debuginfo:
mame-debuginfo
mame-debuginfo(x86-32)
mame:
bundled(bgfx)
bundled(lua-zlib)
bundled(luafilesystem)
bundled(lzma-sdk)
bundled(softfloat)
config(mame)
mame
mame(x86-32)
mame-data-software-lists:
mame-data-software-lists
Source checksums
----------------
https://github.com/mamedev/mame/releases/download/mame0175/mame0175s.exe :
CHECKSUM(SHA256) this package :
fcca637d56dac8dd7eb42d3cff59cf0fc858e3744958fe898252380e25473567
CHECKSUM(SHA256) upstream package :
fcca637d56dac8dd7eb42d3cff59cf0fc858e3744958fe898252380e25473567
http://mamedev.org/releases/whatsnew_0175.txt :
CHECKSUM(SHA256) this package :
b40dbfe8f610e3abaeb80fd512a3e76e42ba3a63c9911c5630728b8aebd4fd68
CHECKSUM(SHA256) upstream package :
b40dbfe8f610e3abaeb80fd512a3e76e42ba3a63c9911c5630728b8aebd4fd68
Generated by fedora-review 0.6.1 (f03e4e7) last change: 2016-05-02
Command line :/usr/bin/fedora-review -c -m fedora-rawhide-i386 -rn
mame-0.175-1.fc24.src.rpm
Buildroot used: fedora-rawhide-i386
Active plugins: Generic, Shell-api, C/C++
Disabled plugins: Java, Python, fonts, SugarActivity, Ocaml, Perl, Haskell, R,
PHP
Disabled flags: EXARCH, DISTTAG, EPEL5, BATCH, EPEL6
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
