https://bugzilla.redhat.com/show_bug.cgi?id=1354184
--- Comment #7 from Raphael Groner <projects...@smart.ms> --- Task info: http://koji.fedoraproject.org/koji/taskinfo?taskID=14849719 (In reply to Igor Gnatenko from comment #2) > > Provides: cmake(%{modname}) > I thought that it should come automatically... Rex? Confirmed and fixed. It's a magic internal feature of rpmbuild. > > Requires: %{name} = %{version}-%{release} > Missing %{?_isa} Fixed. > > %cmake > I would recommend to make out-of-tree builds What are out-of-tree builds? Do you mean to not build binaries into source folder? If yes, fixed. > Others from first glance looks great! Thanks. (In reply to Igor Gnatenko from comment #2) > Issues: > ======= > - ldconfig called in %post and %postun if required. > Note: /sbin/ldconfig not called in qhttpengine > See: http://fedoraproject.org/wiki/Packaging/Guidelines#Shared_Libraries > - %check is present and all tests pass. > Note: test suite is not built/ran > - qhttpengine-devel.x86_64: E: useless-provides cmake(QHttpEngine) > Note: yeah, remove it > - BuildRequires: gcc-c++ is missing > - Would be great to build docs as well All fixed, except tests. I don't know how to build/run the tests, please help. (In reply to Igor Gnatenko from comment #4) > > Requires: cmake > also add here %{?_isa} as well, because package installs cmake files in > %{_libdir} Fixed. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
