https://bugzilla.redhat.com/show_bug.cgi?id=1353606
--- Comment #13 from Julien Enselme <juj...@jujens.eu> --- > I think it would be helpful to put what you told me in Comment #2 in the spec > file as a comment, to make it as clear as possible why there are two packages > that seem to provide the same functionality in Fedora. Done. > Typo: ^unversinned^unversioned In fact, this comment is useless here. I did a copy/paste from another SPEC in which it was. I'll correct the type there. Comment removed. > Would be good to justify git release, as opposed to taking a published > release from pypi: https://pypi.python.org/pypi/pytoml. I tend to prefer pypi (no need to bother about commits) and remove pre built egg-info. However, here the license file was missing in the zip file from pypi. So I chose github. I just added a comment for that. > Actually, if doing the install from github, it should be easy to run the > tests as a %check using the instructions in the upstream README. Sadly no. We can't just use git submodules because it requires network access and pull code that is not from the package. The good way to do this would be to package the go program that include the tests file. I did that for python-toml that rely on golang-github-BurntSushi-toml-test. The problem is pytoml cannot pass this suite since it is outdated. The maintainer of pytoml uses his own fork of golang-github-BurntSushi-toml-test which has no release. So until improvement on that side, I think it's better not to run check within %check and trust the upstream maintainer not to release broken stuff. Adding a comment about that in the SPEC for future information. SPEC: http://dl.jujens.eu/SPECS/python-pytoml.spec SRPM: http://dl.jujens.eu/SRPMS/python-pytoml-0.1.10-2.gitd883c7c.fc24.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
