https://bugzilla.redhat.com/show_bug.cgi?id=1346038
Douglas Schilling Landgraf <dougsl...@redhat.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Flags|needinfo?(dougsland@redhat. |
|com) |
--- Comment #17 from Douglas Schilling Landgraf <dougsl...@redhat.com> ---
Hi,
A few additional comments:
$ fedora-review --rpm-spec -n python-blivet1-1.20.3-3.fc25.src.rpm
INFO: Processing local files: python-blivet1-1.20.3-3.fc25.src.rpm
INFO: Getting .spec and .srpm Urls from : Local files in /home/fedora
INFO: --> SRPM url: file:///home/fedora/python-blivet1-1.20.3-3.fc25.src.rpm
INFO: Using review directory: /home/fedora/python-blivet1
ERROR: 'Cannot find spec file in srpm' (logs in
/home/fedora/.cache/fedora-review.log)
This is caused because your spec file is called python-blivet.spec not
python-blivet1.spec.
I have other question now, I see you are package maint. of python-blivet
package, why not use the current spec to create a subpackage of python2 and
python3 ? No need to create a new package/review "python-blivet1", just add the
new subpackages and rebuild it, like:
python2-blivet
python3-blivet
"Common spec file example"
https://fedoraproject.org/wiki/Packaging:Python#Example_common_spec_file
You can always examine the others reviews and specs:
https://lists.fedoraproject.org/archives/search?mlist=package-review%40lists.fedoraproject.org&q=python
Finally, recommend you to use global instead of define in your python-blivet:
https://fedoraproject.org/wiki/Packaging:Guidelines#.25global_preferred_over_.25define
From my point of view, we should close this bug and please proceed in the
python-blivet spec. Please let me know your thoughts.
Thanks!
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
