https://bugzilla.redhat.com/show_bug.cgi?id=970972
Athmane Madjoudj <athma...@gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |athma...@gmail.com
Assignee|nob...@fedoraproject.org |athma...@gmail.com
Flags| |fedora-review?
--- Comment #5 from Athmane Madjoudj <athma...@gmail.com> ---
Before doing full review, please consider the following points (You still need
a sponsor, sadly I'm not):
1) You dont need "%{__rm} -fr %{buildroot}%{python_sitelib}/paramiko" , since
the tarball does not bundle paramiko
2) You need to switch to python2 macros since Fabric is python2-only (Fabric2
will support py3 but that it built on top of Invoke/Paramiko)
3) You should run the test suite in %check section
4) if you are not planning to support EL5, you could remove
"%defattr(-,root,root,-)"
5) You must include a license file (using %license macro), already included in
the tarball => LICENSE
6) Not a blocker: after quick look into the source code, i did not see any dnf
support in package_* operations, which could make this package unusable in
Fedora if yum script (dnf wrapper) is removed from base distro.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
