https://bugzilla.redhat.com/show_bug.cgi?id=1362626
Igor Gnatenko <ignate...@redhat.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Flags|fedora-review? |
--- Comment #3 from Igor Gnatenko <ignate...@redhat.com> ---
> %define commit 0054ae4cc15ea715148e65d4390fa774c37bb0aa
%global commit 0054ae4cc15ea715148e65d4390fa774c37bb0aa
%global shortcommit %(c=%{commit}; echo ${c:0:7})
> Version: 0.0
Version: 0
> Release: 1.20160802git0054ae4c%{?dist}
Release: 0.1git%{shortcommit}%{?dist}
> License: GPLv2
didn't check carefully, but I suppose GPLv2+
> Source0:
> https://github.com/MartinBriza/MediaWriter/archive/%{commit}.tar.gz
Source0: %{url}/archive/%{commit}/%{name}-%{shortcommit}.tar.gz
> BuildRequires: libappstream-glib
why would you need that? you don't install/validate any of appstream xmls.
> Requires: udisks2
actually as part of F25 we replaced udisks2 with storaged, so probably makes
sense to fix it.
> mkdir %{_target_platform}
move to %prep
> %{qmake_qt5} PREFIX=/usr ..
don't hardcode "/usr", use %{_prefix}. Also not sure if you really use it in
upstream.
> make %{?_smp_mflags} -C %{_target_platform}
%make_build -C %{_target_platform}
> ls -l %{buildroot}
drop it.
> %{_bindir}/mediawriter
%{_bindir}/%{name}
> %{_libexecdir}/mediawriter/helper
then who owns %{_libexecdir}/mediawriter/ ?
just use %{_libexecdir}/%{name}/
* Missing BuildRequires: gcc-c++
* I guess all Requires should have %{?_isa}
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
