https://bugzilla.redhat.com/show_bug.cgi?id=1365745
Igor Gnatenko <ignate...@redhat.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Flags| |fedora-review?
--- Comment #1 from Igor Gnatenko <ignate...@redhat.com> ---
> Summary: A cross platform gui client for Fwknop
remove "A" from the beginning. Actually I would prefer to have just "GUI client
for Fwknop".
> Group: Applications/Internet
not needed and not used.
> Source:
> https://incomsystems.biz/fwknop-gui/downloads/fwknop-gui-%{version}.tar.gz
Source: %{url}/downloads/%{name}-%{version}.tar.gz
> BuildRequires: qrencode-devel
BuildRequires: pkgconfig(libqrencode)
> Requires: fwknop
> Requires: wxGTK3
> Requires: gpgme
> Requires: qrencode
not needed, linked dynamically from binary
> %setup -q -n fwknop-gui
%autosetup -n %{name}
> make %{?_smp_mflags}
%make_build
> make install DESTDIR=%{buildroot}
%make_install
> install -D fwknop-gui.appdata.xml
> %{buildroot}/%{_datadir}/appdata/fwknop-gui.appdata.xml
1. add "-p" and "-m0644" to install
2. drop "/" after %{buildroot}
3. replace "fwknop-gui" with "%{name}"
> desktop-file-validate %{buildroot}%{_datadir}/applications/fwknop-gui.desktop
> appstream-util validate-relax --nonet
> %{buildroot}/%{_datadir}/appdata/*.appdata.xml
1. drop "/" after %{buildroot}
2. replace "fwknop-gui" with "%{name}"
3. Move to separate %check section
> %doc %{_mandir}/man8/*
%doc %{_mandir}/man8/%{name}.8*
> %attr(0755,root,root) %{_bindir}/fwknop-gui
> %attr(0644,root,root) %{_datadir}/applications/fwknop-gui.desktop
> %attr(0644,root,root) %{_datadir}/pixmaps/fwknop-gui.png
> %attr(0644,root,root) %{_datadir}/appdata/fwknop-gui.appdata.xml
1. no need to specify attrs manually
2. replace "fwknop-gui" with "%{name}"
* Missing BuildRequires: gcc-c++
* Missing BuildRequires: make
* Consider building out-of-tree build:
%prep
...
mkdir %{_target_platform}
%build
pushd %{_target_platform}
%cmake ..
popd
%make_build -C %{_target_platform}
%install
%make_install -C %{_target_platform}
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
