https://bugzilla.redhat.com/show_bug.cgi?id=1307271
--- Comment #5 from Giovanni <da...@openmailbox.org> --- Hello Diogo I've been looking at your spec file, and here I've got a couple of comments to add up. 1) The name of the downloaded tarball (or zip) from github can be specified by using this nice trick: Your URL is: https://github.com/dmelo/vswm/archive/%{version}.zip You can specify: https://github.com/dmelo/vswm/archive/%{version}.zip#/%{module}-%{version}.zip 2) Hard wired filesystem locations should be avoided as suggested by Raphael. I've found this set of macros which you might find useful: https://fedoraproject.org/wiki/Packaging:RPMMacros 3) The "install" command is suggested for the creation of directories (`install -d`) and for the insertion of files (`install vswm $RPM_BUILD_ROOT%{_bindir}`) Cheers :) -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
