https://bugzilla.redhat.com/show_bug.cgi?id=1367569
Parag AN(पराग) <panem...@gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Flags|fedora-review? |fedora-review+
--- Comment #11 from Parag AN(पराग) <panem...@gmail.com> ---
(In reply to Giovanni from comment #9)
> Hello Parag
>
> In reply to Comment 7:
>
> 1) Done. I found a bit weird the fact that rpmdev-bumpspec is not using the
> angular bracket. However I've fixed it manually.
When I tried this
rpmdev-bumpspec per-PFT.spec
I can see the angular bracket in the newly added changelog entry. Not sure what
is missing at your system.
>
> 2) I've fixed the README files upstream, however the SPEC file is pointing
> with Source0 to the archive of version 1.0.3. In order to enable the new
> README I should bump the version of the whole package and probably
> re-publish on CPAN too. The same applies to APP::PFT 1.0.5.
I will not block this review for this README update issue but good if you can
do next release soon and update this package in Fedora.
>
> 3) Thanks for the suggestion. I've used tangerine as suggested, and you will
> find the updated SPEC (links follow). Just out of curiosity I've checked
> with mock if the RPM was constructed with the original set of
> `BuildRequires:`, and it turned out to be feasible nevertheless (the missing
> `BuildRequires:` were not installed as transitive dependencies!). I think
> however it's good to be conservative and to rely on the tangerine tool.
I see that some BuildRequires you added are installed by just "perl" package
and some are by their own packages. Feel free to contact perl developers in
#fedora-perl IRC channel for more information on tagerine tool.
>
> Finally, I'm currently involved in the review of someone else's package:
> https://bugzilla.redhat.com/show_bug.cgi?id=1307271
Thank you for doing some package review.
>
> SPEC:
> http://copr-dist-git.fedorainfracloud.org/cgit/dacav/pft/perl-PFT.git/plain/
> perl-PFT.spec
> SRPM:
> https://copr-be.cloud.fedoraproject.org/results/dacav/pft/fedora-rawhide-
> x86_64/00446658-perl-PFT/perl-PFT-1.0.3-4.fc26.src.rpm
This looks good.
APPROVED this package.
Please follow
https://fedoraproject.org/wiki/Package_Review_Process#Contributor page step 8
OR
https://fedoraproject.org/wiki/New_package_process_for_existing_contributors
page step 8
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
