https://bugzilla.redhat.com/show_bug.cgi?id=1369708
--- Comment #10 from yunying....@intel.com ---
(In reply to Ralf Corsepius from comment #8)
> (In reply to yunying.sun from comment #4)
> > the configure error "cannot run C compiled programs" is there, seems because
> > "%configure" adds an extra flag "-Werror" to CFLAGS, which turns some config
> > warnings to errors. With "./configure", koji build pass.
> >
> > @Igor, is it acceptable to use:
> > CONFIG_SITE=$(pwd)/lib/default_config.site ./configure
> > #%configure
> >
> > instead of:
> > export CONFIG_SITE=$(pwd)/lib/default_config.site
> > %configure
>
> Neither is acceptable. Both ways disable checks configure performs and use
> cached values instead - This way you are tricking yourself by outsmarting
> configure.
>
> Furthermore:
>
> - ./bootstrap belongs into %prep not %configure
>
> - Fedora packages must not install anything into /usr/local.
> I.e. this is not allowed in fedora:
> %files
> %{_prefix}/local/sbin/tpm2_*
>
> - Your src.rpm fails to build for fedora due to missing BuildRequires.
> You'd have to submit these packages.
@Ralf, Igor, I've updated the SPEC & SRPM again:
https://github.com/yunyings/share/blob/master/tpm2-tss.spec
https://github.com/yunyings/share/blob/master/tpm2-tss-1.0-0.1.beta1.el7.src.rpm
This time koji build pass:
http://koji.fedoraproject.org/koji/taskinfo?taskID=15461420
Please help to review again. Thanks.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
