https://bugzilla.redhat.com/show_bug.cgi?id=1149176
--- Comment #18 from Michael Simacek <msima...@redhat.com> --- Looks much better now. Issues I found so far: - There are missing BuildRequires, so the package doesn't build in mock. Most notably "maven-local" package which provides mvn_build. For other maven dependencies, there are some tools which can help you, see: https://fedora-java.github.io/howto/snapshot/index.html#error_missing_dependency - The Release numbering is not correct - you won't be able to update to new snapshots with this scheme. See https://fedoraproject.org/wiki/Packaging:Versioning - section about snapshot packages. - _use_maven variable is always true, do you need it at all? You could get rid of it and the many ifs that use it. - EPEL should contain stable packages that are updated only when there is a compelling reason, similarly to RHEL. I'm not much familiar with EPEL guidelines, but I'm afraid you shouldn't/cannot have snapshot package there. Did you consider packaging stable versions for Fedora and EPEL and using Copr for snapshots? - The %description should be improved - When using mvn_build, you shouldn't specify Requires - they are autogenerated. - Changleog entries should contain release at the end. You can use tools like rpmdev-bumpspec to generate those. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
