https://bugzilla.redhat.com/show_bug.cgi?id=1376149
Jon Ciesla <limburg...@gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |ASSIGNED
Flags|fedora-review? |fedora-review+
--- Comment #1 from Jon Ciesla <limburg...@gmail.com> ---
- rpmlint checks return:
fedora-obsolete-packages.src: W: strange-permission
fedora-obsolete-packages.spec 660
A file that you listed to include in your package has strange permissions.
Usually, a file should have 0644 permissions.
fedora-obsolete-packages.src: W: no-%prep-section
The spec file does not contain a %prep section. Even if some packages don't
directly need it, section markers may be overridden in rpm's configuration to
provide additional "under the hood" functionality. Add the section, even if
empty.
fedora-obsolete-packages.src: W: no-%build-section
The spec file does not contain a %build section. Even if some packages don't
directly need it, section markers may be overridden in rpm's configuration to
provide additional "under the hood" functionality, such as injection of
automatic -debuginfo subpackages. Add the section, even if empty.
fedora-obsolete-packages.src: W: no-%install-section
The spec file does not contain an %install section. Even if some packages
don't directly need it, section markers may be overridden in rpm's
configuration to provide additional "under the hood" functionality. Add the
section, even if empty.
1 packages and 0 specfiles checked; 0 errors, 4 warnings.
Ignorable.
- package meets naming guidelines
- package meets packaging guidelines
- license ( Public Domain ) OK, text in %doc, matches source
- spec file legible, in am. english
- source matches upstream
- package compiles on devel (x86)
- no missing BR
- no unnecessary BR
- no locales
- not relocatable
- owns all directories that it creates
- no duplicate files
- permissions ok
- %clean ok
- macro use consistent
- code, not content
- no need for -docs
- nothing in %doc affects runtime
- no need for .desktop file
Looks great, does what it says on the tin. I might recommend having something
suggesting that new Obsoletes added include a comment saying when they were
added, so they can be pruned after they're no longer relevant.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
