https://bugzilla.redhat.com/show_bug.cgi?id=1362490
--- Comment #25 from Tim Flink <tfl...@redhat.com> --- (In reply to Jared Smith from comment #24) > You're going to need to adjust the license tag on this package. > Licensecheck found several licenses other than Apache in parts of the code > base: > > GPL (v3 or later) > ----------------- > libphutil-8f8e02d47569dce5f035383d8bcbf7a08481e839/support/xhpast/parser. > yacc.cpp > libphutil-8f8e02d47569dce5f035383d8bcbf7a08481e839/support/xhpast/parser. > yacc.hpp Bah, I thought those were covered under the special GPL exception for bison output but I missed the part about "as long as it isn't used as part of a parser generator'. > MIT/X11 (BSD like) > ------------------ > libphutil-8f8e02d47569dce5f035383d8bcbf7a08481e839/externals/jsonlint/LICENSE Why couldn't this be distributed as APL2? Ignoring the GPL3 issue with the bison output, I mean. > You should also set the Version: tag to 0 and the Release: tag to > 0.1.20160806.git%{git_short_version_hash}%{dist} > > If you were to do a second build with that same git hash, it would then be > 0.2.20160806.git%{git_short_version_hash}%{dist}, and so on. > > This way, if/when a version 1.0 comes out, it will be greater than version > 0.x.2016whatever. That makes sense but I'm going to see if I can get more out of Jeroen WRT the potential requires/provides issue he mentioned. I'm not sure if that's been tested at all or if there was a plan to work around the concerns. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org