Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=631558

--- Comment #3 from Alexander Kurtakov <akurt...@redhat.com> 2010-09-09 
06:04:31 EDT ---
Hi Peter,
You took the easiest approach to use ln -s /usr/share/java app/lib
 but this is crying for problems. You can easily miss a build requirement in
your spec file. The preferred way is to keep your lib folder and create
symlinks for each jar.
It is obviously missing some BuildRequires because it is failing to build on my
machine with the following error:
[mkdir] Created dir:
/home/akurtakov/work/runtime-EclipseApplication/arduino/BUILD/arduino-0019/app/bin
    [javac] Compiling 57 source files to
/home/akurtakov/work/runtime-EclipseApplication/arduino/BUILD/arduino-0019/app/bin
    [javac]
/home/akurtakov/work/runtime-EclipseApplication/arduino/BUILD/arduino-0019/app/src/processing/app/Editor.java:44:
package gnu.io does not exist
    [javac] import gnu.io.*;



Also you're using 
Requires: avr-gcc avr-gcc-c++ avr-libc avrdude /usr/bin/avrdude
/etc/avrdude/avrdude.conf
File based requires like /usr/bin/avrdude should be avoided as much as possible
because they make yum download the filelist db of every package in the
repository which is quite big. Just requiring the packages that contains this
file if preferred.

I'll do the official review once such issues are fixed.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

Reply via email to