https://bugzilla.redhat.com/show_bug.cgi?id=1381132

Dominika Krejčí <dkre...@redhat.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |dkre...@redhat.com



--- Comment #1 from Dominika Krejčí <dkre...@redhat.com> ---
Hi Martin, I have some comments.

* The last version of barrust/Wikipedia is 1.4.5 and the commit used in
`Source0` also corresponds with 1.4.5. Why is there 1.4.4 in the `Version` tag?

* The `Source0` url creates directory with ugly name, it should be named
`%{srcname}-%{version}.tar.gz`.

* It is useless to create a %{sum} macro. Just write the content to `Summary`
and in the rest of the file you can use %{summary} marco. ;)

* Rather then `python-requests` be more specific and use `python2-requests`,
wherever it is possible.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

Reply via email to