https://bugzilla.redhat.com/show_bug.cgi?id=1382926
--- Comment #1 from Petr Pisar <ppi...@redhat.com> ---
URL and Source0 addresses are usable. Ok.
Source archive (SHA-256:
f834cf093b16d4ba813ccd8e72c44b759e50a23726bb50004da2b7a3cca5a0aa) is original.
Ok.
Summary verified from lib/HTTP/MultiPartParser.pod. Ok.
Description verified from lib/HTTP/MultiPartParser.pod. Ok.
License verified from README, lib/HTTP/MultiPartParser.pod. Ok.
inc/Module/Install/Can.pm contains XS code but is not used, noarch BuildArch is
Ok.
FIX: Build-requires `make' (perl-HTTP-MultiPartParser.spec:32).
FIX: Build-require `perl(Cwd)' (t/030_basic.t:11).
FIX: Build-require `perl(Data::Dumper)' (t/lib/PAML.pm:8).
FIX: Build-require `perl(Exporter)' (t/lib/PAML.pm:17).
FIX: Build-require `perl(FindBin)' (t/030_basic.t:6).
FIX: Build-require `perl(IO::File)' (t/lib/PAML.pm:9).
FIX: Build-require `perl(lib)' (t/030_basic.t:7).
FIX: Build-require `perl(vars)' (t/035_headers.t:28).
FIX: Either unbundle the ./inc files and build-require the Module::Install*
modules whose functions are called from Makefile.PL or build-require
dependencies of the bundled code (`perl(File::Find)' in
inc/Module/Install.pm:23, `perl(File::Path)' im inc/Module/Install.pm:24 etc.).
TODO: Package eg/example.pl as a documentation.
All tests pass. Ok.
$ rpmlint perl-HTTP-MultiPartParser.spec
../SRPMS/perl-HTTP-MultiPartParser-0.01-1.fc26.src.rpm
../RPMS/noarch/perl-HTTP-MultiPartParser-0.01-1.fc26.noarch.rpm
2 packages and 1 specfiles checked; 0 errors, 0 warnings.
$ rpm -q -lv -p ../RPMS/noarch/perl-HTTP-MultiPartParser-0.01-1.fc26.noarch.rpm
drwxr-xr-x 2 root root 0 Oct 26 15:08
/usr/share/doc/perl-HTTP-MultiPartParser
-rw-r--r-- 1 root root 42 Oct 23 2013
/usr/share/doc/perl-HTTP-MultiPartParser/Changes
-rw-r--r-- 1 root root 4260 Oct 23 2013
/usr/share/doc/perl-HTTP-MultiPartParser/README
-rw-r--r-- 1 root root 2937 Oct 26 15:08
/usr/share/man/man3/HTTP::MultiPartParser.3pm.gz
drwxr-xr-x 2 root root 0 Oct 26 15:08
/usr/share/perl5/vendor_perl/HTTP
-rw-r--r-- 1 root root 8285 Oct 22 2013
/usr/share/perl5/vendor_perl/HTTP/MultiPartParser.pm
-rw-r--r-- 1 root root 4064 Oct 23 2013
/usr/share/perl5/vendor_perl/HTTP/MultiPartParser.pod
File permissions and layout is Ok.
$ rpm -q --requires -p
../RPMS/noarch/perl-HTTP-MultiPartParser-0.01-1.fc26.noarch.rpm | sort -f |
uniq -c
1 perl(:MODULE_COMPAT_5.24.0)
1 perl(Carp)
1 perl(Scalar::Util)
1 perl(strict)
1 perl(warnings)
1 rpmlib(CompressedFileNames) <= 3.0.4-1
1 rpmlib(FileDigests) <= 4.6.0-1
1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1
1 rpmlib(PayloadIsXz) <= 5.2-1
Binary requires are Ok.
$ rpm -q --provides -p
../RPMS/noarch/perl-HTTP-MultiPartParser-0.01-1.fc26.noarch.rpm | sort -f |
uniq -c
1 perl(HTTP::MultiPartParser) = 0.01
1 perl-HTTP-MultiPartParser = 0.01-1.fc26
Binary provides are Ok.
$ resolvedeps rawhide
../RPMS/noarch/perl-HTTP-MultiPartParser-0.01-1.fc26.noarch.rpm
Binary dependencies resolvable. Ok.
Package builds in F26
(http://koji.fedoraproject.org/koji/taskinfo?taskID=16208042). Ok.
Otherwise the package is in line with Fedora and Perl packaging guidelines.
Please correct the `FIX' items, consider fixing `TODO' items, and provide a new
spec file.
Resolution: Package NOT approved.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
