https://bugzilla.redhat.com/show_bug.cgi?id=1391487
--- Comment #3 from Nick Bebout <n...@fedoraproject.org> --- Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed Issues: ======= - Package contains BR: python2-devel or python3-devel - Development (unversioned) .so files in -devel subpackage, if present. Note: Unversioned so-files directly in %_libdir. See: http://fedoraproject.org/wiki/Packaging/Guidelines#DevelPackages - Package does not contain duplicates in %files. Note: warning: File listed twice: /usr/lib64/libnextcloudsync.so See: http://fedoraproject.org/wiki/Packaging/Guidelines#DuplicateFiles - Package installs a %{name}.desktop using desktop-file-install or desktop- file-validate if there is such a file. - update-desktop-database is invoked in %post and %postun if package contains desktop file(s) with a MimeType: entry. Note: desktop file(s) with MimeType entry in nextcloud-client-dolphin See: http://fedoraproject.org/wiki/Packaging:ScriptletSnippets#desktop- database ===== MUST items ===== C/C++: [ ]: Package does not contain kernel modules. [ ]: Package contains no static executables. [x]: Header files in -devel subpackage, if present. [x]: ldconfig called in %post and %postun if required. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. Generic: [ ]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [ ]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "GPL (v2 or later)", "*No copyright* GPL (v2)", "Unknown or generated", "*No copyright* Public domain", "*No copyright* BSD (3 clause)", "LGPL (v3 or later)", "LGPL (v2.1)", "BSD (2 clause)", "LGPL (v2.1 or later)", "*No copyright* GPL (v2 or later)", "GPL (v2)". 70 files have unknown license. Detailed output of licensecheck in /home/nebebout/1391487-nextcloud-client/licensecheck.txt [ ]: License file installed when any subpackage combination is installed. [ ]: If the package is under multiple licenses, the licensing breakdown must be documented in the spec. [ ]: Package requires other packages for directories it uses. Note: No known owner of /usr/lib64/qt5/plugins/kf5/overlayicon, /usr/share/nextcloud, /usr/lib64/nextcloud, /usr/share/nextcloud/i18n [ ]: Package must own all directories that it creates. Note: Directories without known owners: /usr/share/icons/hicolor/72x72/apps, /usr/lib64/qt5/plugins/kf5/overlayicon, /usr/share/icons/hicolor/72x72, /usr/share/icons/hicolor/22x22/apps, /usr/share/icons/hicolor/32x32/apps, /usr/share/icons/hicolor/16x16/apps, /usr/share/icons/hicolor/128x128/apps, /usr/share/icons/hicolor/64x64, /usr/share/icons/hicolor/256x256/apps, /usr/share/icons/hicolor/16x16, /usr/share/icons/hicolor/48x48/apps, /usr/share/icons/hicolor, /usr/share/nextcloud, /usr/share/icons/hicolor/512x512/apps, /usr/share/icons/hicolor/128x128, /usr/share/icons/hicolor/32x32, /usr/share/icons/hicolor/64x64/apps, /usr/share/icons/hicolor/22x22, /usr/share/nextcloud/i18n, /usr/share/icons/hicolor/512x512, /usr/share/icons/hicolor/48x48, /usr/lib64/nextcloud, /usr/share/icons/hicolor/256x256 [ ]: %build honors applicable compiler flags or justifies otherwise. [ ]: Package contains no bundled libraries without FPC exception. [ ]: Changelog in prescribed format. [ ]: Sources contain only permissible code or content. [ ]: %config files are marked noreplace or the reason is justified. Note: No (noreplace) in %config /etc/Nextcloud/sync-exclude.lst [ ]: Development files must be in a -devel package [ ]: Package uses nothing in %doc for runtime. [ ]: Package consistently uses macros (instead of hard-coded directory names). [ ]: Package is named according to the Package Naming Guidelines. [ ]: Package does not generate any conflict. [ ]: Package obeys FHS, except libexecdir and /usr/target. [ ]: If the package is a rename of another package, proper Obsoletes and Provides are present. [ ]: Requires correct, justified where necessary. [ ]: Spec file is legible and written in American English. [ ]: Package contains systemd file(s) if in need. [ ]: gtk-update-icon-cache is invoked in %postun and %posttrans if package contains icons. Note: icons in nextcloud-client [ ]: Useful -debuginfo package or justification otherwise. [ ]: Package is not known to require an ExcludeArch tag. [ ]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 10240 bytes in 1 files. [ ]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package does not own files or directories owned by other packages. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Package contains desktop file if it is a GUI application. [x]: Dist tag is present. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: No %config files under /usr. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local Python: [ ]: Python eggs must not download any dependencies during the build process. [ ]: A package which is used by another package via an egg interface should provide egg info. [ ]: Package meets the Packaging Guidelines::Python [x]: Binary eggs must be removed in %prep ===== SHOULD items ===== Generic: [ ]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [ ]: Final provides and requires are sane (see attachments). [ ]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in nextcloud-client-libs , nextcloud-client-devel , nextcloud-client- nautilus , nextcloud-client-nemo , nextcloud-client-dolphin , nextcloud-client-debuginfo [ ]: Package functions as described. [ ]: Latest version is packaged. [ ]: Package does not include license text files separate from upstream. [ ]: Patches link to upstream bugs/comments/lists or are otherwise justified. [ ]: Scriptlets must be sane, if used. [ ]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [ ]: Package should compile and build into binary rpms on all supported architectures. [ ]: %check is present and all tests pass. [ ]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Uses parallel make %{?_smp_mflags} macro. [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [ ]: Large data in /usr/share should live in a noarch subpackage if package is arched. Note: Arch-ed rpms have a total of 3276800 bytes in /usr/share [x]: Rpmlint is run on debuginfo package(s). Note: No rpmlint messages. [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: nextcloud-client-2.2.4-3.fc26.x86_64.rpm nextcloud-client-libs-2.2.4-3.fc26.x86_64.rpm nextcloud-client-devel-2.2.4-3.fc26.x86_64.rpm nextcloud-client-nautilus-2.2.4-3.fc26.x86_64.rpm nextcloud-client-nemo-2.2.4-3.fc26.x86_64.rpm nextcloud-client-dolphin-2.2.4-3.fc26.x86_64.rpm nextcloud-client-debuginfo-2.2.4-3.fc26.x86_64.rpm nextcloud-client-2.2.4-3.fc26.src.rpm nextcloud-client.x86_64: W: no-documentation nextcloud-client.x86_64: W: no-manual-page-for-binary nextcloud nextcloud-client.x86_64: W: no-manual-page-for-binary nextcloudcmd nextcloud-client-libs.x86_64: W: conffile-without-noreplace-flag /etc/Nextcloud/sync-exclude.lst nextcloud-client-devel.x86_64: W: only-non-binary-in-usr-lib nextcloud-client-devel.x86_64: W: no-documentation nextcloud-client-nautilus.x86_64: W: summary-not-capitalized C nextcloud client nautilus extension nextcloud-client-nautilus.x86_64: W: no-documentation nextcloud-client-nemo.x86_64: W: no-documentation nextcloud-client-dolphin.x86_64: E: invalid-soname /usr/lib64/libnextclouddolphinpluginhelper.so libnextclouddolphinpluginhelper.so nextcloud-client-dolphin.x86_64: W: no-documentation nextcloud-client.src:113: W: setup-not-quiet 8 packages and 0 specfiles checked; 1 errors, 11 warnings. Rpmlint (debuginfo) ------------------- Checking: nextcloud-client-debuginfo-2.2.4-3.fc26.x86_64.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings. Rpmlint (installed packages) ---------------------------- nextcloud-client-nemo.x86_64: W: no-documentation nextcloud-client-dolphin.x86_64: E: invalid-soname /usr/lib64/libnextclouddolphinpluginhelper.so libnextclouddolphinpluginhelper.so nextcloud-client-dolphin.x86_64: W: no-documentation nextcloud-client-devel.x86_64: W: only-non-binary-in-usr-lib nextcloud-client-devel.x86_64: W: no-documentation nextcloud-client.x86_64: W: no-documentation nextcloud-client.x86_64: W: no-manual-page-for-binary nextcloudcmd nextcloud-client.x86_64: W: no-manual-page-for-binary nextcloud nextcloud-client-nautilus.x86_64: W: summary-not-capitalized C nextcloud client nautilus extension nextcloud-client-nautilus.x86_64: W: no-documentation nextcloud-client-libs.x86_64: W: conffile-without-noreplace-flag /etc/Nextcloud/sync-exclude.lst 7 packages and 0 specfiles checked; 1 errors, 10 warnings. Requires -------- nextcloud-client-nemo (rpmlib, GLIBC filtered): nemo nemo-python nextcloud-client-dolphin (rpmlib, GLIBC filtered): /sbin/ldconfig dolphin libKF5Completion.so.5()(64bit) libKF5ConfigCore.so.5()(64bit) libKF5CoreAddons.so.5()(64bit) libKF5JobWidgets.so.5()(64bit) libKF5KIOCore.so.5()(64bit) libKF5KIOWidgets.so.5()(64bit) libKF5Service.so.5()(64bit) libKF5WidgetsAddons.so.5()(64bit) libQt5Core.so.5()(64bit) libQt5Core.so.5(Qt_5)(64bit) libQt5Core.so.5(Qt_5.7)(64bit) libQt5Gui.so.5()(64bit) libQt5Network.so.5()(64bit) libQt5Network.so.5(Qt_5)(64bit) libQt5Widgets.so.5()(64bit) libQt5Widgets.so.5(Qt_5)(64bit) libc.so.6()(64bit) libgcc_s.so.1()(64bit) libm.so.6()(64bit) libnextclouddolphinpluginhelper.so()(64bit) libstdc++.so.6()(64bit) libstdc++.so.6(CXXABI_1.3)(64bit) rtld(GNU_HASH) nextcloud-client-devel (rpmlib, GLIBC filtered): libnextcloudsync.so.0()(64bit) libocsync.so.0()(64bit) nextcloud-client-libs(x86-64) nextcloud-client (rpmlib, GLIBC filtered): /bin/sh libQt5Concurrent.so.5()(64bit) libQt5Core.so.5()(64bit) libQt5Core.so.5(Qt_5)(64bit) libQt5Core.so.5(Qt_5.7)(64bit) libQt5DBus.so.5()(64bit) libQt5DBus.so.5(Qt_5)(64bit) libQt5Gui.so.5()(64bit) libQt5Gui.so.5(Qt_5)(64bit) libQt5Network.so.5()(64bit) libQt5Network.so.5(Qt_5)(64bit) libQt5Solutions_LockedFile-2.4.so.1()(64bit) libQt5Solutions_SingleApplication-2.6.so.1()(64bit) libQt5Sql.so.5()(64bit) libQt5WebKit.so.5()(64bit) libQt5WebKitWidgets.so.5()(64bit) libQt5WebKitWidgets.so.5(Qt_5)(64bit) libQt5Widgets.so.5()(64bit) libQt5Widgets.so.5(Qt_5)(64bit) libQt5Xml.so.5()(64bit) libQt5Xml.so.5(Qt_5)(64bit) libc.so.6()(64bit) libcrypto.so.1.1()(64bit) libcrypto.so.1.1(OPENSSL_1_1_0)(64bit) libdl.so.2()(64bit) libgcc_s.so.1()(64bit) libgcc_s.so.1(GCC_3.0)(64bit) libm.so.6()(64bit) libnextcloudsync.so.0()(64bit) libocsync.so.0()(64bit) libqt5keychain.so.1()(64bit) librt.so.1()(64bit) libsqlite3.so.0()(64bit) libssl.so.1.1()(64bit) libstdc++.so.6()(64bit) libstdc++.so.6(CXXABI_1.3)(64bit) libz.so.1()(64bit) nextcloud-client-libs(x86-64) rtld(GNU_HASH) nextcloud-client-debuginfo (rpmlib, GLIBC filtered): nextcloud-client-nautilus (rpmlib, GLIBC filtered): nautilus nautilus-python nextcloud-client-libs (rpmlib, GLIBC filtered): /sbin/ldconfig config(nextcloud-client-libs) ld-linux-x86-64.so.2()(64bit) libQt5Core.so.5()(64bit) libQt5Core.so.5(Qt_5)(64bit) libQt5Core.so.5(Qt_5.7)(64bit) libQt5Gui.so.5()(64bit) libQt5Gui.so.5(Qt_5)(64bit) libQt5Network.so.5()(64bit) libQt5Network.so.5(Qt_5)(64bit) libQt5Widgets.so.5()(64bit) libQt5Widgets.so.5(Qt_5)(64bit) libc.so.6()(64bit) libcrypto.so.1.1()(64bit) libcrypto.so.1.1(OPENSSL_1_1_0)(64bit) libgcc_s.so.1()(64bit) libgcc_s.so.1(GCC_3.0)(64bit) libm.so.6()(64bit) libocsync.so.0()(64bit) libqt5keychain.so.1()(64bit) librt.so.1()(64bit) libsqlite3.so.0()(64bit) libstdc++.so.6()(64bit) libstdc++.so.6(CXXABI_1.3)(64bit) libz.so.1()(64bit) rtld(GNU_HASH) Provides -------- nextcloud-client-nemo: nextcloud-client-nemo nextcloud-client-nemo(x86-64) nextcloud-client-dolphin: libnextclouddolphinpluginhelper.so()(64bit) nextcloud-client-dolphin nextcloud-client-dolphin(x86-64) nextcloud-client-devel: mirall-devel nextcloud-client-devel nextcloud-client-devel(x86-64) nextcloud-client-static nextcloud-client: appdata() appdata(nextcloud-client.appdata.xml) application() application(nextcloud.desktop) mirall nextcloud-client nextcloud-client(x86-64) nextcloud-client-debuginfo: nextcloud-client-debuginfo nextcloud-client-debuginfo(x86-64) nextcloud-client-nautilus: mirall-nautilus nextcloud-client-nautilus nextcloud-client-nautilus(x86-64) nextcloud-client-libs: config(nextcloud-client-libs) libnextcloudsync.so.0()(64bit) libocsync.so.0()(64bit) mirall-common nextcloud-client-libs nextcloud-client-libs(x86-64) Unversioned so-files -------------------- nextcloud-client-dolphin: /usr/lib64/libnextclouddolphinpluginhelper.so nextcloud-client-dolphin: /usr/lib64/qt5/plugins/kf5/overlayicon/nextclouddolphinoverlayplugin.so nextcloud-client-dolphin: /usr/lib64/qt5/plugins/nextclouddolphinactionplugin.so Source checksums ---------------- https://github.com/nextcloud/client_theming/archive/v2.2.4.tar.gz : CHECKSUM(SHA256) this package : 55a16505c8551cb8e6af5d2f570b6d4384f33a75a79810864e1d4555d53dedf9 CHECKSUM(SHA256) upstream package : 55a16505c8551cb8e6af5d2f570b6d4384f33a75a79810864e1d4555d53dedf9 https://download.owncloud.com/desktop/stable/owncloudclient-2.2.4.tar.xz : CHECKSUM(SHA256) this package : f313534f7cdae686beeaa6670d9e3586a627ce78b67cab6e42a448a675d9e7d3 CHECKSUM(SHA256) upstream package : f313534f7cdae686beeaa6670d9e3586a627ce78b67cab6e42a448a675d9e7d3 Generated by fedora-review 0.6.1 (f03e4e7) last change: 2016-05-02 Command line :/usr/bin/fedora-review -b 1391487 -m fedora-rawhide-x86_64 Buildroot used: fedora-rawhide-x86_64 Active plugins: Python, Generic, Shell-api, C/C++ Disabled plugins: Java, SugarActivity, fonts, Haskell, Ocaml, Perl, R, PHP Disabled flags: EXARCH, DISTTAG, EPEL5, BATCH, EPEL6 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
