https://bugzilla.redhat.com/show_bug.cgi?id=1392606
--- Comment #2 from Jason Tibbitts <ti...@math.uh.edu> --- Dang it, I swear one version of the package I made had perl-generators in there. Unfortunately I started with cpanspec, and it really needs to be fixed. I fixed a lot of its output but it would have been simpler to start from scratch, I think. In fact, I realize it's sufficiently useless that I went ahead and remove mention of it from the Perl guidelines entirely. Anyway, cpanspec seems to be poor enough now that I just removed reference to it from the Perl guidelines. I didn't even know about the NO_PACKLIST, and the deletion of empty directories by default. That's great. I sure wish cpanspec knew about it, too. Is %_fixperms still required? And is it still required to call "make pure_install"? If "make install" worked we could just recommend %make_install. Here are new files: Updated spec: https://www.math.uh.edu/~tibbs/review/perl-Encode-IMAPUTF7/perl-Encode-IMAPUTF7.spec Updated SRPM: https://www.math.uh.edu/~tibbs/review/perl-Encode-IMAPUTF7/perl-Encode-IMAPUTF7-1.05-2.fc25.src.rpm (f25 this time so that perl-generators isn't there by default) But, a note, from the person who wrote the packaging guidelines relating to build dependencies: I did not add the dependencies on coreutils and findutils. If you're asking others to add them, I would kindly ask that you please stop doing so as it only causes confusion among the packagers. The guidelines guarantee that RPM can run basic shell scripts and actually build packages. You get mv and find and tar and sed and patch. (I did add a dep on make, which elicits a complaint from fedora-review. Sometimes you just can't win.) The intent was never to give anyone the impression that those were required. I went ahead and altered the Perl guidelines to use wording closer to that of the main guidelines to try and minimize any confusion. But if you have suggestions for any other clarifications I might add (short of just including a complete list, which is what we want to avoid) then please let me know. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
