https://bugzilla.redhat.com/show_bug.cgi?id=1359402
--- Comment #14 from Tim Fenn <tim.f...@gmail.com> --- (In reply to Antonio Trande from comment #13) > Package Review > ============== > > Legend: > [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated > [ ] = Manual review needed > > > Issues: > ======= > - Package does not use a name that already exists. > Note: A package with this name already exists. Please check > https://admin.fedoraproject.org/pkgdb/package/coot > See: > > https://fedoraproject.org/wiki/Packaging/ > NamingGuidelines#Conflicting_Package_Names > > - Add 'Requires: lib%{name}%{?_isa} = %{version}-%{release}' to > libcoot-devel. > Done. > - Add 'Requires: python2-lib%{name}%{?_isa} = %{version}-%{release}' to > python2-libcoot-devel. > Done. > - 'coot-data' must be a noarch package. > Main package requires 'coot-data' as a noarch dependence. > > Requires: %{name}-data = %{version}-%{release} > Done. > - 'coot-doc' is a stand-alone package that must provide a license file. > Done. > - Following lines can be removed > > %post -n python2-libcoot > /sbin/ldconfig > > %postun -n python2-libcoot > /sbin/ldconfig > > - ldconfig scriptlets can be written in this way > > %post -n libcoot -p /sbin/ldconfig > %postun -n libcoot -p /sbin/ldconfig > Done. > - Please, remove those macros in the comments or silence them with %%. > Done. > - Fix strange-permission warnings (set them with 644) > > coot.src: W: strange-permission reference-structures.tar.gz 444 Fixed. > coot.src: W: strange-permission coot.in 755 > This is set to 755 as its processed by autoconf to generate the coot script that starts the main program. I've also discussed the testing of the build with upstream, and there are several files/custom scripts required to run the tests. I've asked upstream to consider streamlining this in some way, but for now I've disabled the "make check", since by itself it does nothing. Also, the package was updated to version 0.8.7 (which fixes some of the smaller issues, such as removing AM_PROG_CC_STDC). https://timfenn.fedorapeople.org/coot.spec https://timfenn.fedorapeople.org/coot-0.8.7-1.fc24.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
