https://bugzilla.redhat.com/show_bug.cgi?id=1376035
--- Comment #11 from Miroslav Suchý <msu...@redhat.com> ---
(In reply to Parag AN(पराग) from comment #10)
> Few things I want to note here
>
> 1) python_provide macro is not used which I think is available on all Fedora
> as well as EPEL6+
As of today on Fedora 25:
$ rpm --eval '%python_provide foo'
%python_provide: ERROR: foo not recognized.
I will add it there later when it will actually work.
> 2) with the new upstream release I can't see modlint now
???
> 3) I don't know why following macros are need to be explicitly added to spec
> file which are already available by python2-rpm-macros package.
> %{!?__python2: %global __python2 /usr/bin/python2}
> %{!?py2_build: %global py2_build %{expand: CFLAGS="%{optflags}" %{__python2}
> setup.py %{?py_setup_args} build --executable="%{__python2} -s"}}
> %{!?py2_install: %global py2_install %{expand: CFLAGS="%{optflags}"
> %{__python2} setup.py %{?py_setup_args} install -O1 --skip-build --root
> %{buildroot}}
OK. I will check it if it is available in EPEL too and will work with upstream
on removal when it make sense.
> 4) there should be some uniformity needed for python2 and python3 macros. I
> see above 3 lines are defined in spec file for python2 but the same is not
> there for python3.
I suppose that is because of EPEL (and I do not create python3 subpackage
there, so just python2 variants). I just checked it and those macros are even
available in EPEL6. So I will create PR for upstream and will remove it there.
> APPROVED.
Thank you.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
