https://bugzilla.redhat.com/show_bug.cgi?id=1396232
Igor Gnatenko <ignate...@redhat.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |ASSIGNED
Assignee|nob...@fedoraproject.org |ignate...@redhat.com
Flags| |fedora-review?
--- Comment #1 from Igor Gnatenko <ignate...@redhat.com> ---
* CFLAGS/LDFLAGS are not used
export CFLAGS="%{optflags}"
export LDFLAGS="%{__global_ldflags}"
but it still requires some patching of Makefile `=` -> `?=`
* Missing BuildRequires: gcc
* You should try to version library (though I'm not sure how much it matters
here, probably doesn't at all)
* echo is not needed in %build
* instead of make you should use %make_build (e.g. %make_build -C src)
* there are some tests, so try to build / run them
* instead of doing mkdir, you can pass `-D` to install
Apart from that, looks good ;)
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
