https://bugzilla.redhat.com/show_bug.cgi?id=1391334
--- Comment #2 from Link Dupont <l...@sub-pop.net> ---
Thank you for the review! This raised a couple questions when I was examining
the issues.
1) FreeOrion appears to bundle libGiGi
FreeOrion bundles libGiGi. There is an external libGiGi project, but during my
research, I found that Debian supports bundling libGiGi with their freeorion
package. This excerpt from their README.source file:
Bundled GG (libgigi) library:
At the moment GG is not feasible to maintain separately:
* It is used exclusively by freeorion.
* FreeOrion maintains a fork of GG in FreeOrion's source tree.
* FreeOrion's GG fork is better maintained and needs less patches.
* For example the original libgigi library doesn't build with gcc-4.7
(requires gcc-4.6) while from FreeOrion's source tree
it builds fine with gcc-4.7 and doesn't need the "vector.patch".
* GG is not a proper library (more like a plugin) and therefore
not suitable for packaging as a standalone libgigi(-dev) package.
Would I need to submit a bundle library exception to the FPC for this?
2) FSF address incorrect
I noticed a rpmlint warning about an incorrect FSF address. When I looked at
the COPYING file shipped by upstream, it does have the correct address. The
only difference was a comma (,) inserted between the ZIP code and the country.
I feel like ignoring this lint error is okay, since the address is correct,
just formatted funny.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
