https://bugzilla.redhat.com/show_bug.cgi?id=1398922

Igor Gnatenko <ignate...@redhat.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |177841 (FE-NEEDSPONSOR)



--- Comment #7 from Igor Gnatenko <ignate...@redhat.com> ---
* ./configure --prefix=%{_prefix} --libdir=%{_libdir} -> %configure
Usually, but unfortunately it's not the case right now. Main problem is that
CFLAGS/LDFLAGS are ignored.
you can do something like:
export CFLAGS="%{__global_cflags}"
exprot LDFLAGS="%{__global_ldflags}" before configure call
* rm -rf $RPM_BUILD_ROOT is not needed
* I think license is GPLv2+, not GPLv2
* Missing BuildRequires: gcc
* I would recommend make URL without macro, so it will be easily clickable

Otherwise, looks good from first glance.

Unfortunately you are not in packagers group, so you need a sponsor.
Looks like you need to start from
https://fedoraproject.org/wiki/Join_the_package_collection_maintainers#Introduce_yourself
point.


Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=177841
[Bug 177841] Tracker: Review requests from new Fedora packagers who need a
sponsor
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

Reply via email to