https://bugzilla.redhat.com/show_bug.cgi?id=1392977
Jan Chaloupka <jchal...@redhat.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Flags|fedora-review? |fedora-review+
--- Comment #8 from Jan Chaloupka <jchal...@redhat.com> ---
Given only binaries are built, the spec file conforms to the current packaging
guidelines. However, I would recommend to update the spec file with:
- replace make all in %build section with actual commands so the LDFLAGS can be
set and %gobuild macro used instead of go command
- partial unbundle the deps (the package depends on kubernetes and docker which
are by its nature unbundeable at the moment)
- once the intel issue is fixed (worth openning upstream issue/bz for it),
extend the list of supported architectures to all supported
- provide Godeps.json (or its variant) as a part of the devel subpackage once
https://github.com/kubernetes-incubator/cri-o/issues/280 is resolved and the
devel rpm is built.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
