https://bugzilla.redhat.com/show_bug.cgi?id=1392090
--- Comment #6 from Peter Robinson <pbrobin...@gmail.com> --- > spec file line 2 reads: > %define with_tests 0 > > Guidelines sugest we use %global instead, as you can see in [1]. Note that > this is not a must. > > The Summary tag ends with period a period. Please see [2]. Those two are minor quirks I would fix on commit. Do you want me to update them? > After your feedback on those points I will consider this review done, sice > the package looks good. > > We would still need to find a solution for bug 1392089 in order to include > python2-zeroconf in fedora, since this bug depends on it. I'll deal with that. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
