https://bugzilla.redhat.com/show_bug.cgi?id=1409138
--- Comment #7 from Michael Schwendt <bugs.mich...@gmx.net> --- > added the option -q for silent running because rpmlint was complaining. Hmmm. Just don't only try to please rpmlint. Decide yourself whether what rpmlint suggests is helpful or not. The setup-not-quiet warning from rpmlint is just a warning, it's not an error not to use -q with %setup. For this tiny package, adding -q reduces the build output log by less than 30 lines. On the contrary, if it were a source archive with hundreds or thousands of files, using -q might make much more sense. And still, a package maintainer may prefer default output of %setup, because displaying the source archive files list in a build.log makes it searchable, for example. You never know what may be discovered thanks to that, such as a [new] bundled library or an incorrectly generated tarball (with the right source dir only in a subdir, or "unclean" and with prebuilt files) -- both cases have happened before. Even if the majority of packages add -q to %setup, there's nothing about it in the guidelines. And with %autosetup, quiet output is the default, but one can add -v for verbose output. ;-) -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
