https://bugzilla.redhat.com/show_bug.cgi?id=1371158
--- Comment #10 from Ingvar Hagelund <ing...@linpro.no> --- (In reply to Petr Pisar from comment #9) Thanks again, Petr. I'll try again. Updated srpm and spec here (did not bump release tag) https://ingvar.fedorapeople.org/ebtree/ebtree.spec https://ingvar.fedorapeople.org/ebtree/ebtree-6.0.8-4.fc25.src.rpm > -fPIC -DPIC are compiler options. Not linker options. The should be added to > CFLAGS. Not LDFLAGS. Right. Fixed > I think %check is for running tests. Not for compiling code. But it does not > matter much. I can take away a few lines by moving it %build, and just run the check under %check, so it's an improvement as well. Fixed. > (...)The SOREL should be "0.1", SOMIN whatever you want (actually you does > not have to use it), and -soname option would be "libebtree.so.$(SOREL)" > only. > > The idea is to have soname different from whatever upstream could use when > he decided to start using soname. uh, ok. Something like this, then: SOREL = 0.1 (...) libebtree.so: $(OBJS) $(CC) $(LDFLAGS) -shared -Wl,-soname,libebtree.so.$(SOREL) -o libebtree.so.$(SOREL) $(OBJS) ln -sf libebtree.so.$(SOREL) libebtree.so Better now? Ingvar -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
