https://bugzilla.redhat.com/show_bug.cgi?id=1406797
Iryna Shcherbina <ishch...@redhat.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |ishch...@redhat.com
--- Comment #1 from Iryna Shcherbina <ishch...@redhat.com> ---
Hi Filip,
The spec file looks good, but please consider the following suggestions:
* License file must be installed when any subpackage combination is installed.
Please add license to python-ansicolor-doc subpackage.
* There is no need to define `sum` macro, it is generated automatically after
you set the first Summary tag. So you should just set the Summary of the main
package and use %{summary} macro in your python[23]- subpackages.
* It is better to avoid using wildcards in the %files section to have an idea
what is installed with the package. Doing the following change will make it
more safe (same for %{python2_sitelib}):
%{python3_sitelib}/*
change to
%{python3_sitelib}/%{srcname}
%{python3_sitelib}/%{srcname}-%{version}-py?.?.egg-info
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
