https://bugzilla.redhat.com/show_bug.cgi?id=1411984



--- Comment #5 from Michael Schwendt <bugs.mich...@gmx.net> ---
> We can simplify it to
> 
>   %{_datadir}/%{name}/*

No, that's not enough, because it would not include the directory
%{_datadir}/{%name} itself. See comment 1. 


> Because of the suggestions from comment #2 I couldn't use the Makefile. 

Not true:

  %make_install INSTALL_PROG="install -p"

I would always prefer a working Makefile, if included, and modify it, if
necessary, compared with the extra burden that would be imposed on you by
having to install everything yourself in the %install section and keeping that
section accurate. You could even ship the addition of "-p" upstream.


> %clean
> rm -rf %{buildroot}

https://fedoraproject.org/wiki/Packaging:Guidelines#Tags_and_Sections


> %{_mandir}/man1/%{name}.1.*

One dot to much. It would not included an uncompressed manual page. This one
would:

%{_mandir}/man1/%{name}.1*

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

Reply via email to