https://bugzilla.redhat.com/show_bug.cgi?id=1415190
--- Comment #3 from Marcel Haerry <mh+fed...@scrit.ch> --- > > this is by intend, as the python3 package contains all the documentation and > > manpages. I wasn't sure whether this is the right way to package the python2 > > variant of the service. > > Can you make the package conditionally add the manpages to the "base" > package depending on the distribution? I'll try that one. > Python 2 is the default on all > supported distributions so far. Well if I read https://fedoraproject.org/wiki/Packaging:Python#Python_Version_Support then I understand it that the default target is Python 3 and Python 2 is nice-to-have. I also thought about only building a python3 version for Fedora and a python 2 version for EPEL. I tried to understand the whole Python packaging guidelines, but I think lots of things are in transition atm. and I'm not sure what the current best-practice is in all the edge-cases. For example I also did not include any service files or so in the python2 package on Fedora. So one could really question, what the benefit from the python2 package is and whether we should build a python2 package at all. It's kinda easy for pure libraries, but binaries and services make it a bit more complex. So I would suggest to then build only the python3 version. > And in the EPEL 7 build the man pages are > not there. The problem is, that the version of sphinx in EPEL 7 is not new enough to build the man pages. That's why I excluded them. How would you go forward in such a case? From the update guidelines, I think it's not feasible to get the new version sphinx in EPEL, as it has breaking changes, afair. > The only thing that I see that is wrong in the package is the license field. > It's not BSD but GPLv3: > > https://github.com/DonnchaC/onionbalance/blob/develop/COPYING Good catch! Fixed. So atm, I got a regression from a recently updated library, which makes the build failing atm. :/ I need to look into that one more in detail before being able to do a new test build. Nevertheless, we can already discuss the situation above. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
