https://bugzilla.redhat.com/show_bug.cgi?id=1415143
--- Comment #17 from Hans de Goede <hdego...@redhat.com> --- (In reply to leigh scott from comment #16) > - Add 10_nvidia_wayland.json to libs sub-package > > > Spec URL: > https://leigh123linux.fedorapeople.org/pub/review/egl-wayland/4/egl-wayland. > spec > > > SRPM URL: > https://leigh123linux.fedorapeople.org/pub/review/egl-wayland/4/egl-wayland- > 1.0.0-0.4.20170120git743d702.fc26.src.rpm Thanks, looks good now, only you still have an unnecessary -devel sub-package, nothing is going to compile time link aginst the .so so you can simply remove the .so symlink in %install and drop the -devel. With that fixed this looks good to me and can be approved (after a full review is done, but I do not believe that will catch anything else). -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
